Fixes regression when opening tabs in background with pinned tabs

chrome/browser/ui/tabs/tab_strip_model_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 
 #include <map>
 #include <string>
 
 #include "base/files/file_path.h"
@@ skipping 2670 matching lines @@
   WebContents* moved_contents = strip_src.DetachWebContentsAt(1);
   EXPECT_EQ(contents2, moved_contents);
 
   // Attach the tab to the destination tab strip.
   strip_dst.AppendWebContents(moved_contents, true);
   EXPECT_TRUE(strip_dst.IsTabBlocked(0));
 
   strip_dst.CloseAllTabs();
   strip_src.CloseAllTabs();
 }
+
+// Verifies ordering of tabs opened via link from a pinned tab with subsequent

[Peter Kasting, 2015/05/11 22:10:32]

Nit: link -> a link, with -> with a

[sky, 2015/05/11 22:13:56]

Done.

+// pinned tab.
+TEST_F(TabStripModelTest, LinkClicksWithPinnedTabOrdering) {
+  TabStripDummyDelegate delegate;
+  TabStripModel strip(&delegate, profile());
+
+  // Open two pages, pinned.
+  WebContents* page_a_contents = CreateWebContents();
+  strip.AddWebContents(page_a_contents, -1,
+                       ui::PAGE_TRANSITION_AUTO_TOPLEVEL,
+                       TabStripModel::ADD_ACTIVE | TabStripModel::ADD_PINNED);
+  WebContents* page_b_contents = CreateWebContents();
+  strip.AddWebContents(page_b_contents, -1,
+                       ui::PAGE_TRANSITION_AUTO_TOPLEVEL,
+                       TabStripModel::ADD_ACTIVE | TabStripModel::ADD_PINNED);
+
+  // Activate the first tab (a).
+  strip.ActivateTabAt(0, true);
+
+  // Open two more tabs as link clicks. The first tab (c) should appear after
+  // the pinned tabs followed by the second tab (d).
+  WebContents* page_c_contents = CreateWebContents();
+  WebContents* page_d_contents = CreateWebContents();
+  strip.AddWebContents(page_c_contents, -1, ui::PAGE_TRANSITION_LINK,
+                       TabStripModel::ADD_NONE);
+  strip.AddWebContents(page_d_contents, -1, ui::PAGE_TRANSITION_LINK,
+                       TabStripModel::ADD_NONE);
+
+  EXPECT_EQ(2, strip.GetIndexOfWebContents(page_c_contents));
+  EXPECT_EQ(3, strip.GetIndexOfWebContents(page_d_contents));
+  strip.CloseAllTabs();
+}