Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1131233002: Fixup reference for svg/animations/viewspec-checkaspectparams.html (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
Reviewers:
davve, Xianzhu
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fixup reference for svg/animations/viewspec-checkaspectparams.html Use the expected 'viewBox' and 'preserveAspectRatio' instead, and modify the <rect> to match what's in the resources/ svg-file. Drop a redundant semicolon from the view-spec (this is not a parsing test). BUG=235256 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M LayoutTests/svg/animations/viewspec-checkaspectparams.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/animations/viewspec-checkaspectparams-expected.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
fs
5 years, 7 months ago (2015-05-08 09:27:23 UTC) #2
davve
Non-owner LGTM Test (still) present in TestExpectations. Intended?
5 years, 7 months ago (2015-05-08 11:48:57 UTC) #3
fs
On 2015/05/08 11:48:57, David Vest wrote: > Non-owner LGTM In LayoutTests/ "everybody" is an owener ...
5 years, 7 months ago (2015-05-08 11:55:33 UTC) #4
davve
On 2015/05/08 11:55:33, fs wrote: > On 2015/05/08 11:48:57, David Vest wrote: > > Non-owner ...
5 years, 7 months ago (2015-05-08 12:06:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131233002/1
5 years, 7 months ago (2015-05-08 12:15:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195110
5 years, 7 months ago (2015-05-08 12:19:20 UTC) #8
Xianzhu
5 years, 7 months ago (2015-05-08 15:56:45 UTC) #9
Message was sent while issue was closed.
On 2015/05/08 11:55:33, fs wrote:
> On 2015/05/08 11:48:57, David Vest wrote:
> > Non-owner LGTM
> 
> In LayoutTests/ "everybody" is an owener ;-)
>  
> > Test (still) present in TestExpectations. Intended?
> 
> I forgot to include the context:
> https://codereview.chromium.org/1098273002/#msg22
> 
> (Still no idea how it managed to pass CQ in the first place...)

It seems that some layout update and/or painting in the test is scheduled in
next cycle. The issue was exposed when I changed the final pixel dump to
asynchronous. (https://codereview.chromium.org/1127013005/).

Powered by Google App Engine
This is Rietveld 408576698