Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: runtime/bin/directory_win.cc

Issue 11312242: Revised CL for customisable logging (replacing printfs). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/directory_win.cc
===================================================================
--- runtime/bin/directory_win.cc (revision 14903)
+++ runtime/bin/directory_win.cc (working copy)
@@ -2,14 +2,12 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-#include "bin/directory.h"
-
#include <errno.h>
#include <sys/stat.h>
-#include "bin/platform.h"
+#include "bin/directory.h"
Ivan Posva 2012/11/15 07:43:17 Please do not change the include order. Within dir
gram 2012/11/15 21:16:50 Done.
+#include "bin/log.h"
-
static int SetOsErrorMessage(char* os_error_message,
int os_error_message_len) {
int error_code = GetLastError();
@@ -23,7 +21,7 @@
NULL);
if (message_size == 0) {
if (GetLastError() != ERROR_INSUFFICIENT_BUFFER) {
- fprintf(stderr, "FormatMessage failed %d\n", GetLastError());
+ Log::PrintErr("FormatMessage failed %d\n", GetLastError());
}
snprintf(os_error_message, os_error_message_len, "OS Error %d", error_code);
}

Powered by Google App Engine
This is Rietveld 408576698