runtime/bin/dbg_connection_android.cc - Issue 11312242: Revised CL for customisable logging (replacing printfs).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/dbg_connection_android.cc

Issue 11312242: Revised CL for customisable logging (replacing printfs). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/dbg_connection_android.cc

===================================================================

--- runtime/bin/dbg_connection_android.cc (revision 14903)

+++ runtime/bin/dbg_connection_android.cc (working copy)

@@ -7,6 +7,7 @@

#include <stdlib.h>

#include <sys/epoll.h>

+#include "bin/log.h"

siva 2012/11/15 18:46:48 Please sort alphabetically (should go after fdutil

gram 2012/11/15 21:16:50 Done.

#include "bin/dbg_connection.h"

#include "bin/fdutils.h"

#include "bin/socket.h"

@@ -32,7 +33,7 @@

// Sync message. Not yet implemented.

UNIMPLEMENTED();

} else {

- printf("unexpected: receiving debugger connection event.\n");

+ Log::Print("unexpected: receiving debugger connection event.\n");

UNIMPLEMENTED();

}

« no previous file with comments | « runtime/bin/dbg_connection.cc ('k') | runtime/bin/dbg_connection_linux.cc » ('j') | runtime/bin/directory_win.cc » ('J')