Revised CL for customisable logging (replacing printfs).

runtime/bin/log.h

Index: runtime/bin/log.h
===================================================================
--- runtime/bin/log.h	(revision 0)
+++ runtime/bin/log.h	(revision 0)
@@ -0,0 +1,18 @@
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#ifndef BIN_LOG_H_
+#define BIN_LOG_H_
+
+#include "bin/builtin.h"

[Ivan Posva, 2012/11/15 07:43:17]

Why do you need to include builtin.h here? There are no references to the class
Builtin inside this file.

[gram, 2012/11/15 21:16:50]

Removed.

+
+class Log {
+ public:
+  // Print formatted output to stdout/stderr for debugging.
+  static void Print(const char* format, ...) PRINTF_ATTRIBUTE(1, 2);
+  static void PrintErr(const char* format, ...) PRINTF_ATTRIBUTE(1, 2);
+  static void VFPrint(FILE* stream, const char* format, va_list args);

[siva, 2012/11/15 18:46:48]

Does VFPrint need to be a public function?

I did not see any calls to it from any of the files.

Also you need:
  DISALLOW_ALLOCATION();
  DISALLOW_IMPLICIT_CONSTRUCTORS(Log);
constructs here.

[gram, 2012/11/15 21:16:50]

Done.

+};
+
+#endif  // BIN_LOG_H_