runtime/bin/log.h - Issue 11312242: Revised CL for customisable logging (replacing printfs).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/bin/log.h

Issue 11312242: Revised CL for customisable logging (replacing printfs). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 #ifndef BIN_LOG_H_

	6 #define BIN_LOG_H_

	7

	8 #include "bin/builtin.h"
	Ivan Posva 2012/11/15 07:43:17 Why do you need to include builtin.h here? There a Why do you need to include builtin.h here? There are no references to the class Builtin inside this file. gram 2012/11/15 21:16:50 Removed. Show quoted text On 2012/11/15 07:43:17, Ivan Posva wrote: > Why do you need to include builtin.h here? There are no references to the class > Builtin inside this file. Removed.
	9

	10 class Log {

	11 public:

	12 // Print formatted output to stdout/stderr for debugging.

	13 static void Print(const char* format, ...) PRINTF_ATTRIBUTE(1, 2);

	14 static void PrintErr(const char* format, ...) PRINTF_ATTRIBUTE(1, 2);

	15 static void VFPrint(FILE* stream, const char* format, va_list args);
	siva 2012/11/15 18:46:48 Does VFPrint need to be a public function? I did Does VFPrint need to be a public function? I did not see any calls to it from any of the files. Also you need: DISALLOW_ALLOCATION(); DISALLOW_IMPLICIT_CONSTRUCTORS(Log); constructs here. gram 2012/11/15 21:16:50 Done. Show quoted text On 2012/11/15 18:46:48, siva wrote: > Does VFPrint need to be a public function? > > I did not see any calls to it from any of the files. > > Also you need: > DISALLOW_ALLOCATION(); > DISALLOW_IMPLICIT_CONSTRUCTORS(Log); > constructs here. Done.
	16 };

	17

	18 #endif // BIN_LOG_H_

OLD	NEW

« runtime/bin/gen_snapshot.cc ('K') | « runtime/bin/gen_snapshot.cc ('k') | runtime/bin/log_android.cc » ('j') | runtime/bin/log_android.cc » ('J')