Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/WebKit/chromium/ChangeLog

Issue 11312201: Merge 134009 - WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/WebPagePopupImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/ChangeLog
===================================================================
--- Source/WebKit/chromium/ChangeLog (revision 134336)
+++ Source/WebKit/chromium/ChangeLog (working copy)
@@ -1,3 +1,15 @@
+2012-11-08 Keishi Hattori <keishi@webkit.org>
+
+ WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
+ https://bugs.webkit.org/show_bug.cgi?id=93800
+
+ Reviewed by Kent Tamura.
+
+ We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent.
+
+ * src/WebPagePopupImpl.cpp:
+ (WebKit::WebPagePopupImpl::close): Set m_closing to true.
+
2012-10-31 Keishi Hattori <keishi@webkit.org>
[Chromium] Page popup shows up at wrong locations when root view is scrolled
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/WebPagePopupImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698