Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Side by Side Diff: Source/WebKit/chromium/ChangeLog

Issue 11312201: Merge 134009 - WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/WebPagePopupImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 2012-11-08 Keishi Hattori <keishi@webkit.org>
2
3 WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
4 https://bugs.webkit.org/show_bug.cgi?id=93800
5
6 Reviewed by Kent Tamura.
7
8 We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent.
9
10 * src/WebPagePopupImpl.cpp:
11 (WebKit::WebPagePopupImpl::close): Set m_closing to true.
12
1 2012-10-31 Keishi Hattori <keishi@webkit.org> 13 2012-10-31 Keishi Hattori <keishi@webkit.org>
2 14
3 [Chromium] Page popup shows up at wrong locations when root view is scro lled 15 [Chromium] Page popup shows up at wrong locations when root view is scro lled
4 https://bugs.webkit.org/show_bug.cgi?id=100830 16 https://bugs.webkit.org/show_bug.cgi?id=100830
5 17
6 Reviewed by Kent Tamura. 18 Reviewed by Kent Tamura.
7 19
8 We need to account for the scroll position when calculating the root vie w rectangle in the screen. 20 We need to account for the scroll position when calculating the root vie w rectangle in the screen.
9 21
10 * src/DateTimeChooserImpl.cpp: 22 * src/DateTimeChooserImpl.cpp:
(...skipping 2397 matching lines...) Expand 10 before | Expand all | Expand 10 after
2408 2420
2409 [Chromium-Win] Implement LocaleWin::dateFormat 2421 [Chromium-Win] Implement LocaleWin::dateFormat
2410 https://bugs.webkit.org/show_bug.cgi?id=98117 2422 https://bugs.webkit.org/show_bug.cgi?id=98117
2411 2423
2412 Reviewed by Kentaro Hara. 2424 Reviewed by Kentaro Hara.
2413 2425
2414 * tests/LocaleWinTest.cpp: 2426 * tests/LocaleWinTest.cpp:
2415 (TEST_F): Add tests for LocaleWin::dateFormat. 2427 (TEST_F): Add tests for LocaleWin::dateFormat.
2416 2428
2417 == Rolled over to ChangeLog-2012-10-02 == 2429 == Rolled over to ChangeLog-2012-10-02 ==
OLDNEW
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/WebPagePopupImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698