Issue 11312201: Merge 134009 - WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11312201: Merge 134009 - WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close (Closed)

Created:
8 years, 1 month ago by keishi

Modified:
8 years, 1 month ago

Reviewers:
keishi

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Visibility:
Public.

Merge 134009 - WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close https://bugs.webkit.org/show_bug.cgi?id=93800 Reviewed by Kent Tamura. We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent. * src/WebPagePopupImpl.cpp: (WebKit::WebPagePopupImpl::close): Set m_closing to true. TBR=keishi@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134337

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	Source/WebKit/chromium/ChangeLog	View		1 chunk	+12 lines, -0 lines	0 comments	Download
	M	Source/WebKit/chromium/src/WebPagePopupImpl.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 1 (0 generated)