Issue 11312185: Function::GetScriptOrigin should supply sourceURL when script name is not available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11312185: Function::GetScriptOrigin should supply sourceURL when script name is not available. (Closed)

Created:
8 years, 1 month ago by Jakob Kummerow

Modified:
8 years, 1 month ago

Reviewers:
Yang

CC:
v8-dev, eustas

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Function::GetScriptOrigin should supply sourceURL when script name is not available. GetScriptOrigin is used for DevTools instrumentation. If inspected call-site is inside "eval" then returned script name is "undefined". To fix this problem we can use the "nameOrSourceURL" method of script-wrapper. This is a re-upload of https://codereview.appspot.com/6811090/ for the purpose of landing. BUG=159413 Committed: https://code.google.com/p/v8/source/detail?r=12929

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -15 lines)			Patch
M	src/api.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/handles.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/handles.cc	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	src/isolate.cc	View	2 chunks	+1 line, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Can I get a quick rubber-stamp to appease the OWNERS check?

8 years, 1 month ago (2012-11-12 12:33:19 UTC) #1

Yang

8 years, 1 month ago (2012-11-12 12:34:01 UTC) #2

On 2012/11/12 12:33:19, Jakob wrote:
> Can I get a quick rubber-stamp to appease the OWNERS check?

LGTM

Expand Messages | Collapse Messages