Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: src/api.cc

Issue 11312185: Function::GetScriptOrigin should supply sourceURL when script name is not available. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/handles.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3717 matching lines...) Expand 10 before | Expand all | Expand 10 after
3728 Handle<Value> Function::GetInferredName() const { 3728 Handle<Value> Function::GetInferredName() const {
3729 i::Handle<i::JSFunction> func = Utils::OpenHandle(this); 3729 i::Handle<i::JSFunction> func = Utils::OpenHandle(this);
3730 return Utils::ToLocal(i::Handle<i::Object>(func->shared()->inferred_name())); 3730 return Utils::ToLocal(i::Handle<i::Object>(func->shared()->inferred_name()));
3731 } 3731 }
3732 3732
3733 3733
3734 ScriptOrigin Function::GetScriptOrigin() const { 3734 ScriptOrigin Function::GetScriptOrigin() const {
3735 i::Handle<i::JSFunction> func = Utils::OpenHandle(this); 3735 i::Handle<i::JSFunction> func = Utils::OpenHandle(this);
3736 if (func->shared()->script()->IsScript()) { 3736 if (func->shared()->script()->IsScript()) {
3737 i::Handle<i::Script> script(i::Script::cast(func->shared()->script())); 3737 i::Handle<i::Script> script(i::Script::cast(func->shared()->script()));
3738 i::Handle<i::Object> scriptName = GetScriptNameOrSourceURL(script);
3738 v8::ScriptOrigin origin( 3739 v8::ScriptOrigin origin(
3739 Utils::ToLocal(i::Handle<i::Object>(script->name())), 3740 Utils::ToLocal(scriptName),
3740 v8::Integer::New(script->line_offset()->value()), 3741 v8::Integer::New(script->line_offset()->value()),
3741 v8::Integer::New(script->column_offset()->value())); 3742 v8::Integer::New(script->column_offset()->value()));
3742 return origin; 3743 return origin;
3743 } 3744 }
3744 return v8::ScriptOrigin(Handle<Value>()); 3745 return v8::ScriptOrigin(Handle<Value>());
3745 } 3746 }
3746 3747
3747 3748
3748 const int Function::kLineOffsetNotFound = -1; 3749 const int Function::kLineOffsetNotFound = -1;
3749 3750
(...skipping 2927 matching lines...) Expand 10 before | Expand all | Expand 10 after
6677 6678
6678 v->VisitPointers(blocks_.first(), first_block_limit_); 6679 v->VisitPointers(blocks_.first(), first_block_limit_);
6679 6680
6680 for (int i = 1; i < blocks_.length(); i++) { 6681 for (int i = 1; i < blocks_.length(); i++) {
6681 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]); 6682 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]);
6682 } 6683 }
6683 } 6684 }
6684 6685
6685 6686
6686 } } // namespace v8::internal 6687 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/handles.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698