Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1131203002: Revert of Allow loading holes from holey smi arrays (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Allow loading holes from holey smi arrays (patchset #2 id:20001 of https://codereview.chromium.org/1134483002/) Reason for revert: Shouldn't unconditionally load holes since it tanks performance. I'll change it in a follow-up to only do it if the IC ever saw it happen. Original issue's description: > Allow loading holes from holey smi arrays > > BUG= > > Committed: https://crrev.com/eab5bb5390fab79d063f29398377c6d181963dde > Cr-Commit-Position: refs/heads/master@{#28298} TBR=mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/43d5319143c885c8acb0cd2f71726526ba97a2b7 Cr-Commit-Position: refs/heads/master@{#28309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
Created Revert of Allow loading holes from holey smi arrays
5 years, 7 months ago (2015-05-08 07:28:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131203002/1
5 years, 7 months ago (2015-05-08 07:28:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 07:29:01 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/43d5319143c885c8acb0cd2f71726526ba97a2b7 Cr-Commit-Position: refs/heads/master@{#28309}
5 years, 7 months ago (2015-05-08 07:29:10 UTC) #4
mvstanton
5 years, 7 months ago (2015-05-08 07:34:09 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698