src/ia32/lithium-codegen-ia32.cc - Issue 1131203002: Revert of Allow loading holes from holey smi arrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 1131203002: Revert of Allow loading holes from holey smi arrays (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 4ff65fbb9eeeb85c907a5eb768faee380773c8b2..3f1bab73eefc75fdd9867240b01493b038153136 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -3186,8 +3186,7 @@

DeoptimizeIf(equal, instr, Deoptimizer::kHole);

}

} else if (instr->hydrogen()->hole_mode() == CONVERT_HOLE_TO_UNDEFINED) {

- DCHECK(instr->hydrogen()->elements_kind() == FAST_HOLEY_SMI_ELEMENTS ||

- instr->hydrogen()->elements_kind() == FAST_HOLEY_ELEMENTS);

+ DCHECK(instr->hydrogen()->elements_kind() == FAST_HOLEY_ELEMENTS);

Label done;

__ cmp(result, factory()->the_hole_value());

__ j(not_equal, &done);

« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »