Issue 11312029: Revert 165230 - Merge 164399 - Make MultiAnimation take time param and slow down tab highlight

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11312029: Revert 165230 - Merge 164399 - Make MultiAnimation take time param and slow down tab highlight (Closed)

Created:
8 years, 1 month ago by xiyuan

Modified:
8 years, 1 month ago

Reviewers:
DaveMoore

CC:
chromium-reviews, tfarina, sadrul, dhollowa+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1271/src/

Visibility:
Public.

More Reviews

Description

Revert 165230 - Merge 164399 - Make MultiAnimation take time param and slow down tab highlight BUG=157981 TEST=None Review URL: https://codereview.chromium.org/11274063 TBR=davemoore@chromium.org Review URL: https://codereview.chromium.org/11359008 TBR=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165271

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -28 lines)			Patch
M	ash/launcher/tabbed_launcher_button.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/search/toolbar_search_animator.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab.cc	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	ui/base/animation/multi_animation.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	ui/base/animation/multi_animation.cc	View	3 chunks	+3 lines, -9 lines	0 comments	Download
M	ui/base/animation/multi_animation_unittest.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

xiyuan

8 years, 1 month ago (2012-11-01 02:44:41 UTC) #2

fyi

cros compile error:
http://master.chrome.corp.google.com:8011/builders/cros%20stable/builds/167/s...
chrome/browser/ui/views/location_bar/suggested_text_view.cc: In member function
‘ui::Animation* SuggestedTextView::CreateAnimation()’:
chrome/browser/ui/views/location_bar/suggested_text_view.cc:79: error: no
matching function for call to
‘ui::MultiAnimation::MultiAnimation(std::vector<ui::MultiAnimation::Part,
std::allocator<ui::MultiAnimation::Part> >&)’
./ui/base/animation/multi_animation.h:91: note: candidates are:
ui::MultiAnimation::MultiAnimation(const ui::MultiAnimation&)
./ui/base/animation/multi_animation.h:48: note:                
ui::MultiAnimation::MultiAnimation(const std::vector<ui::MultiAnimation::Part,
std::allocator<ui::MultiAnimation::Part> >&, base::TimeDelta)

and affects linux and Windows build too
http://master.chrome.corp.google.com:8011/builders/linux64%20stable/builds/17...
http://master.chrome.corp.google.com:8011/builders/win%20stable/builds/156/st...

Expand Messages | Collapse Messages