Issue 11274063: Make MultiAnimation take time param and slow down tab highlight

Issue 11274063: Make MultiAnimation take time param and slow down tab highlight (Closed)

Created:
8 years, 1 month ago by DaveMoore

Modified:
8 years, 1 month ago

Reviewers:
sky, sky1

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make MultiAnimation take time param and slow down tab highlight BUG=157981 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164399

Patch Set 4 : Bad var name #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -11 lines)			Patch
M	ash/launcher/tabbed_launcher_button.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/search/toolbar_search_animator.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	ui/base/animation/multi_animation.h	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/base/animation/multi_animation.cc	View	1 2	3 chunks	+9 lines, -3 lines	0 comments	Download
M	ui/base/animation/multi_animation_unittest.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/11274063/diff/2001/ui/base/animation/multi_animation.cc File ui/base/animation/multi_animation.cc (right): https://codereview.chromium.org/11274063/diff/2001/ui/base/animation/multi_animation.cc#newcode39 ui/base/animation/multi_animation.cc:39: return base::TimeDelta::FromMilliseconds(kDefaultTimerInterval); kDefaultInterval https://codereview.chromium.org/11274063/diff/2001/ui/base/animation/multi_animation.h File ui/base/animation/multi_animation.h (right): https://codereview.chromium.org/11274063/diff/2001/ui/base/animation/multi_animation.h#newcode48 ...

8 years, 1 month ago (2012-10-25 23:14:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/11274063/2003

8 years, 1 month ago (2012-10-25 23:35:40 UTC) #3

commit-bot: I haz the power

8 years, 1 month ago (2012-10-26 17:54:32 UTC) #4

Retried try job too often for step(s) base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, content_browsertests,
content_unittests, crypto_unittests, gpu_unittests, interactive_ui_tests,
ipc_tests, jingle_unittests, media_unittests, nacl_integration, net_unittests,
printing_unittests, remoting_unittests, safe_browsing_tests, sql_unittests,
sync_integration_tests, sync_unit_tests, unit_tests

Expand Messages | Collapse Messages