Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1131163003: Revert "Roll src/third_party/boringssl/src 68de407:65a7e94" (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3936 lines, -5726 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/README.chromium View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/boringssl/boringssl.gypi View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 3 chunks +1 line, -15 lines 0 comments Download
M third_party/boringssl/boringssl_unittest.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/boringssl/err_data.c View 8 chunks +286 lines, -294 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/aes/aesv8-armx.S View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/modes/ghashv8-armx.S View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/aes/aes-armv4.S View 13 chunks +40 lines, -53 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/aes/bsaes-armv7.S View 43 chunks +1152 lines, -1179 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/bn/armv4-mont.S View 13 chunks +155 lines, -166 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/modes/ghash-armv4.S View 14 chunks +159 lines, -166 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha1-armv4-large.S View 23 chunks +122 lines, -126 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha256-armv4.S View 9 chunks +95 lines, -102 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha512-armv4.S View 3 chunks +679 lines, -684 lines 0 comments Download
M third_party/boringssl/linux-x86/crypto/aes/aesni-x86.S View 74 chunks +269 lines, -520 lines 0 comments Download
M third_party/boringssl/linux-x86_64/crypto/aes/aesni-x86_64.S View 38 chunks +58 lines, -444 lines 0 comments Download
M third_party/boringssl/mac-x86/crypto/aes/aesni-x86.S View 74 chunks +269 lines, -524 lines 0 comments Download
M third_party/boringssl/mac-x86_64/crypto/aes/aesni-x86_64.S View 38 chunks +58 lines, -444 lines 0 comments Download
A third_party/boringssl/update_gypi_and_asm.py View 1 chunk +259 lines, -0 lines 0 comments Download
M third_party/boringssl/win-x86/crypto/aes/aesni-x86.asm View 75 chunks +269 lines, -523 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/aes/aesni-x86_64.asm View 40 chunks +59 lines, -463 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
Not sure why your revert isn't in yet. Maybe I'll find out in a second…
5 years, 7 months ago (2015-05-09 04:07:07 UTC) #2
Nico
Jinx. Nevermind then, thanks for the revert :-)
5 years, 7 months ago (2015-05-09 04:08:26 UTC) #3
davidben
5 years, 7 months ago (2015-05-09 04:17:12 UTC) #4
Message was sent while issue was closed.
You probably wouldn't have been able to land this one anyway. I had to re-upload
it with this lovely patch to depot_tools:

diff --git a/third_party/upload.py b/third_party/upload.py
index eac2a3d..de6a9fb 100755
--- a/third_party/upload.py
+++ b/third_party/upload.py
@@ -1062,7 +1062,7 @@ class VersionControlSystem(object):
     """Returns true if data contains a null byte."""
     # Derived from how Mercurial's heuristic, see
     # http://selenic.com/hg/file/848a6658069e/mercurial/util.py#l229
-    return bool(data and "\0" in data)
+    return bool(data and ("\0" in data) or "Karatsuba post-processing" in data)
 
 
 class SubversionVCS(VersionControlSystem):

That's part of why it took a bit longer for my revert to get through. Some of
those files have Latin-1 characters that make Rietveld barf because thank you
OpenSSL and Python 2 strings. :-) (I'll probably try to get rid of them later.
But they're already in the repository because Rietveld *doesn't* break on new
files, only diffs, and we didn't notice until it caused diff problems.)

Powered by Google App Engine
This is Rietveld 408576698