Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1122423007: Roll src/third_party/boringssl/src 68de407:65a7e94 (Closed)

Created:
5 years, 7 months ago by davidben
Modified:
5 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/boringssl/src 68de407:65a7e94 Summary of changes available at: https://boringssl.googlesource.com/boringssl/+log/68de407..65a7e94 This also removes update_gypi_and_asm.py in favor of the script inside BoringSSL proper. BUG=none Committed: https://crrev.com/c80637399c13d7c3e8cb7a16bd5de104feb449e9 Cr-Commit-Position: refs/heads/master@{#329032}

Patch Set 1 #

Patch Set 2 : roll further #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5726 lines, -3936 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/README.chromium View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/boringssl/boringssl.gypi View 1 3 chunks +3 lines, -1 line 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 1 3 chunks +15 lines, -1 line 0 comments Download
M third_party/boringssl/boringssl_unittest.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/boringssl/err_data.c View 8 chunks +294 lines, -286 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/aes/aesv8-armx.S View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/modes/ghashv8-armx.S View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/aes/aes-armv4.S View 13 chunks +53 lines, -40 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/aes/bsaes-armv7.S View 43 chunks +1179 lines, -1152 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/bn/armv4-mont.S View 13 chunks +166 lines, -155 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/modes/ghash-armv4.S View 14 chunks +166 lines, -159 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha1-armv4-large.S View 23 chunks +126 lines, -122 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha256-armv4.S View 9 chunks +102 lines, -95 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha512-armv4.S View 3 chunks +684 lines, -679 lines 0 comments Download
M third_party/boringssl/linux-x86/crypto/aes/aesni-x86.S View 74 chunks +520 lines, -269 lines 0 comments Download
M third_party/boringssl/linux-x86_64/crypto/aes/aesni-x86_64.S View 38 chunks +444 lines, -58 lines 0 comments Download
M third_party/boringssl/mac-x86/crypto/aes/aesni-x86.S View 74 chunks +524 lines, -269 lines 0 comments Download
M third_party/boringssl/mac-x86_64/crypto/aes/aesni-x86_64.S View 38 chunks +444 lines, -58 lines 0 comments Download
D third_party/boringssl/update_gypi_and_asm.py View 1 chunk +0 lines, -259 lines 0 comments Download
M third_party/boringssl/win-x86/crypto/aes/aesni-x86.asm View 75 chunks +523 lines, -269 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/aes/aesni-x86_64.asm View 40 chunks +463 lines, -59 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
davidben
5 years, 7 months ago (2015-05-07 21:05:15 UTC) #2
agl
lgtm
5 years, 7 months ago (2015-05-07 21:08:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122423007/20001
5 years, 7 months ago (2015-05-08 20:12:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-09 02:50:50 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c80637399c13d7c3e8cb7a16bd5de104feb449e9 Cr-Commit-Position: refs/heads/master@{#329032}
5 years, 7 months ago (2015-05-09 02:52:58 UTC) #8
davidben
5 years, 7 months ago (2015-05-09 03:15:22 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1132243002/ by davidben@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder...

Looks like the __STDC_FORMAT_MACROS thing got lost when inttypes.h and BN_FMT_*
were moved to a public header. That it's a public header is... problematic....

Powered by Google App Engine
This is Rietveld 408576698