Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1131163002: Add --port option to adb_gdb to allow simultaneous debugging of browser and render processes. (Closed)

Created:
5 years, 7 months ago by lfg
Modified:
5 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add --port option to adb_gdb to allow simultaneous debugging of browser and render processes. Committed: https://crrev.com/a1639ebf0d2e8501975a06b6cd58998b073531ce Cr-Commit-Position: refs/heads/master@{#328963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/android/adb_gdb View 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
lfg
Hi, can you take a look? Thanks!
5 years, 7 months ago (2015-05-07 21:34:34 UTC) #2
jbudorick
lgtm
5 years, 7 months ago (2015-05-08 01:02:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131163002/1
5 years, 7 months ago (2015-05-08 16:14:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 16:25:03 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 16:26:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1639ebf0d2e8501975a06b6cd58998b073531ce
Cr-Commit-Position: refs/heads/master@{#328963}

Powered by Google App Engine
This is Rietveld 408576698