Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: build/android/adb_gdb

Issue 1131163002: Add --port option to adb_gdb to allow simultaneous debugging of browser and render processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/adb_gdb
diff --git a/build/android/adb_gdb b/build/android/adb_gdb
index 3612f90991bd4c55a67fe092243c822829c8c053..65ec7b20b87df53f1de71e9ac4d31e3cad6c1ee4 100755
--- a/build/android/adb_gdb
+++ b/build/android/adb_gdb
@@ -97,6 +97,7 @@ NDK_DIR=
NO_PULL_LIBS=
PACKAGE_NAME=
PID=
+PORT=
PRIVILEGED=
PRIVILEGED_INDEX=
PROGRAM_NAME="activity"
@@ -147,6 +148,9 @@ for opt; do
--pid=*)
PID=$optarg
;;
+ --port=*)
+ PORT=$optarg
+ ;;
--privileged)
PRIVILEGED=true
;;
@@ -329,6 +333,7 @@ Valid options:
--gdb=<file> Specify host gdb client binary.
--target-arch=<name> Specify NDK target arch.
--adb=<file> Specify host ADB binary.
+ --port=<port> Specify the tcp port to use.
--su-prefix=<prefix> Prepend <prefix> to 'adb shell' commands that are
run by this script. This can be useful to use
@@ -933,7 +938,9 @@ adb shell $COMMAND_PREFIX cp $TMP_TARGET_GDBSERVER $TARGET_GDBSERVER
adb shell rm $TMP_TARGET_GDBSERVER
fail_panic "Could not copy gdbserver to the device!"
-PORT=5039
+if [ -z "$PORT" ]; then
+ PORT=5039
+fi
HOST_PORT=$PORT
TARGET_PORT=$PORT
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698