Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1131123002: Update SHA-1 message in google_chrome_strings.grd. (Closed)

Created:
5 years, 7 months ago by lgarron
Modified:
5 years, 7 months ago
Reviewers:
palmer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update SHA-1 message in google_chrome_strings.grd. crrev.com/1109283003 accidentally changed chrome/app/chromium_strings.grd without copying the change in this file. BUG=461045, 434617, 437466 Committed: https://crrev.com/726260df520a1860105a7b83b9e3e7b221d8cd28 Cr-Commit-Position: refs/heads/master@{#328848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
lgarron
5 years, 7 months ago (2015-05-07 20:40:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131123002/1
5 years, 7 months ago (2015-05-07 20:41:56 UTC) #4
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 7 months ago (2015-05-07 20:41:59 UTC) #6
palmer
lgtm
5 years, 7 months ago (2015-05-07 20:44:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131123002/1
5 years, 7 months ago (2015-05-07 20:46:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 22:00:25 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 22:01:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/726260df520a1860105a7b83b9e3e7b221d8cd28
Cr-Commit-Position: refs/heads/master@{#328848}

Powered by Google App Engine
This is Rietveld 408576698