net/tools/net_watcher/net_watcher.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/net_watcher/net_watcher.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/net_watcher/net_watcher.cc

diff --git a/net/tools/net_watcher/net_watcher.cc b/net/tools/net_watcher/net_watcher.cc

index 8d1d056c5afef34a9649cdf51c5b2d51fdf7384a..02c373adc1c2bc6a57960e0e4006b110859d68ac 100644

--- a/net/tools/net_watcher/net_watcher.cc

+++ b/net/tools/net_watcher/net_watcher.cc

@@ -71,7 +71,7 @@ const char* ConnectionTypeToString(

std::string ProxyConfigToString(const net::ProxyConfig& config) {

scoped_ptr<base::Value> config_value(config.ToValue());

std::string str;

- base::JSONWriter::Write(config_value.get(), &str);

+ base::JSONWriter::Write(*config_value, &str);

return str;

}

« no previous file with comments | « net/tools/get_server_time/get_server_time.cc ('k') | pdf/out_of_process_instance.cc » ('j') | no next file with comments »