net/tools/get_server_time/get_server_time.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/get_server_time/get_server_time.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/get_server_time/get_server_time.cc

diff --git a/net/tools/get_server_time/get_server_time.cc b/net/tools/get_server_time/get_server_time.cc

index 9915e8ee61e93d972ce63e60f0a559a0b0db2f67..fe1c1246a00afc70381db23fabfec0b829991e9b 100644

--- a/net/tools/get_server_time/get_server_time.cc

+++ b/net/tools/get_server_time/get_server_time.cc

@@ -122,7 +122,7 @@ class PrintingLogObserver : public net::NetLog::ThreadSafeObserver {

scoped_ptr<base::Value> params(entry.ParametersToValue());

std::string params_str;

if (params.get()) {

- base::JSONWriter::Write(params.get(), &params_str);

+ base::JSONWriter::Write(*params, &params_str);

params_str.insert(0, ": ");

}

« no previous file with comments | « net/test/spawned_test_server/remote_test_server.cc ('k') | net/tools/net_watcher/net_watcher.cc » ('j') | no next file with comments »