Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: net/test/spawned_test_server/remote_test_server.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/log/write_to_file_net_log_observer.cc ('k') | net/tools/get_server_time/get_server_time.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/test/spawned_test_server/remote_test_server.cc
diff --git a/net/test/spawned_test_server/remote_test_server.cc b/net/test/spawned_test_server/remote_test_server.cc
index 1d1481b9d161e9fa0453fa1ba775f824cac4bb8c..bf2c025185f861a59fc1b71d020dce4f5bfc36b7 100644
--- a/net/test/spawned_test_server/remote_test_server.cc
+++ b/net/test/spawned_test_server/remote_test_server.cc
@@ -103,7 +103,7 @@ bool RemoteTestServer::Start() {
// Generate JSON-formatted argument string.
std::string arguments_string;
- base::JSONWriter::Write(&arguments_dict, &arguments_string);
+ base::JSONWriter::Write(arguments_dict, &arguments_string);
if (arguments_string.empty())
return false;
@@ -123,7 +123,7 @@ bool RemoteTestServer::Start() {
// the remote server.
server_data_dict.SetInteger("port", test_server_port);
std::string server_data;
- base::JSONWriter::Write(&server_data_dict, &server_data);
+ base::JSONWriter::Write(server_data_dict, &server_data);
if (server_data.empty() || !ParseServerData(server_data)) {
LOG(ERROR) << "Could not parse server_data: " << server_data;
return false;
« no previous file with comments | « net/log/write_to_file_net_log_observer.cc ('k') | net/tools/get_server_time/get_server_time.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698