Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: ios/web/web_state/ui/crw_web_controller_observer_unittest.mm

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/tools/compositor_model_bench/render_tree.cc ('k') | ios/web/webui/web_ui_ios_impl.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller_observer_unittest.mm
diff --git a/ios/web/web_state/ui/crw_web_controller_observer_unittest.mm b/ios/web/web_state/ui/crw_web_controller_observer_unittest.mm
index 9fd935874760ce1a5c04dfe98ab245427738b89c..9b99c9a99d17837b7bf1b30e6953291daa51931f 100644
--- a/ios/web/web_state/ui/crw_web_controller_observer_unittest.mm
+++ b/ios/web/web_state/ui/crw_web_controller_observer_unittest.mm
@@ -68,7 +68,7 @@ WEB_TEST_F(CRWUIWebViewWebControllerObserverTest,
base::DictionaryValue command;
command.SetString("command", "test.testMessage");
std::string message;
- base::JSONWriter::Write(&command, &message);
+ base::JSONWriter::Write(command, &message);
this->RunJavaScript([NSString
stringWithFormat:@"__gCrWeb.message.invokeOnHost(%s)", message.c_str()]);
this->WaitForBackgroundTasks();
@@ -91,7 +91,7 @@ WEB_TEST_F(CRWUIWebViewWebControllerObserverTest,
command.SetString("target", "target");
command.SetString("referrerPolicy", "referrerPolicy");
std::string message;
- base::JSONWriter::Write(&command, &message);
+ base::JSONWriter::Write(command, &message);
this->RunJavaScript(
[NSString stringWithFormat:@"__gCrWeb.message.invokeOnHostImmediate(%s)",
message.c_str()]);
@@ -112,7 +112,7 @@ WEB_TEST_F(CRWUIWebViewWebControllerObserverTest,
for (int count = 0; count <= kNumberMessages; count++) {
std::string message;
command.SetInteger("number", count);
- base::JSONWriter::Write(&command, &message);
+ base::JSONWriter::Write(command, &message);
ASSERT_EQ(0U,
[this->fake_web_controller_observer_ commandsReceived].size());
this->RunJavaScript(
« no previous file with comments | « gpu/tools/compositor_model_bench/render_tree.cc ('k') | ios/web/webui/web_ui_ios_impl.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698