ios/web/webui/web_ui_ios_impl.mm - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/webui/web_ui_ios_impl.mm

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/webui/web_ui_ios_impl.mm

diff --git a/ios/web/webui/web_ui_ios_impl.mm b/ios/web/webui/web_ui_ios_impl.mm

index 810f3a7b21a8debf37a432a35f7d7ccb64ae79f1..8913f79d7547d901a425a592e2b88e540927fe97 100644

--- a/ios/web/webui/web_ui_ios_impl.mm

+++ b/ios/web/webui/web_ui_ios_impl.mm

@@ -27,7 +27,7 @@ base::string16 WebUIIOS::GetJavascriptCall(

if (i > 0)

parameters += base::char16(',');

- base::JSONWriter::Write(arg_list[i], &json);

+ base::JSONWriter::Write(*arg_list[i], &json);

parameters += base::UTF8ToUTF16(json);

}

return base::ASCIIToUTF16(function_name) + base::char16('(') + parameters +

« no previous file with comments | « ios/web/web_state/ui/crw_web_controller_observer_unittest.mm ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »