extensions/browser/computed_hashes.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/computed_hashes.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/web_request/web_request_api.cc ('k') | extensions/browser/value_store/leveldb_value_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/computed_hashes.cc

diff --git a/extensions/browser/computed_hashes.cc b/extensions/browser/computed_hashes.cc

index 473ee3c6ba8c7402ce35265ecedf3900200a24d4..35ea525508b7ed34d828755226b9e1c791426a61 100644

--- a/extensions/browser/computed_hashes.cc

+++ b/extensions/browser/computed_hashes.cc

@@ -156,7 +156,7 @@ bool ComputedHashes::Writer::WriteToFile(const base::FilePath& path) {

top_dictionary.SetInteger(kVersionKey, kVersion);

top_dictionary.Set(kFileHashesKey, file_list_.release());

- if (!base::JSONWriter::Write(&top_dictionary, &json))

+ if (!base::JSONWriter::Write(top_dictionary, &json))

return false;

int written = base::WriteFile(path, json.data(), json.size());

if (static_cast<unsigned>(written) != json.size()) {

« no previous file with comments | « extensions/browser/api/web_request/web_request_api.cc ('k') | extensions/browser/value_store/leveldb_value_store.cc » ('j') | no next file with comments »