extensions/browser/api/web_request/web_request_api.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/web_request/web_request_api.cc

diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc

index 7de492e0e56134752d61132d4674c55f18c6c4e7..f6c75274dca5baff22e2f25a09487a06a1055474 100644

--- a/extensions/browser/api/web_request/web_request_api.cc

+++ b/extensions/browser/api/web_request/web_request_api.cc

@@ -2374,7 +2374,7 @@ bool WebRequestInternalEventHandledFunction::RunSync() {

headers_value->GetDictionary(i, &header_value));

if (!FromHeaderDictionary(header_value, &name, &value)) {

std::string serialized_header;

- base::JSONWriter::Write(header_value, &serialized_header);

+ base::JSONWriter::Write(*header_value, &serialized_header);

RespondWithError(event_name,

sub_event_name,

request_id,

« no previous file with comments | « extensions/browser/api/storage/settings_storage_quota_enforcer.cc ('k') | extensions/browser/computed_hashes.cc » ('j') | no next file with comments »