content/browser/webui/web_ui_impl.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/web_ui_impl.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/webui/web_ui_impl.cc

diff --git a/content/browser/webui/web_ui_impl.cc b/content/browser/webui/web_ui_impl.cc

index a9194a992fd6884880577a21aaa7749ec175780b..1f953a2f5e1452ac2c985e1290b70a4c98bab3e7 100644

--- a/content/browser/webui/web_ui_impl.cc

+++ b/content/browser/webui/web_ui_impl.cc

@@ -36,7 +36,7 @@ base::string16 WebUI::GetJavascriptCall(

if (i > 0)

parameters += base::char16(',');

- base::JSONWriter::Write(arg_list[i], &json);

+ base::JSONWriter::Write(*arg_list[i], &json);

parameters += base::UTF8ToUTF16(json);

}

return base::ASCIIToUTF16(function_name) +

« no previous file with comments | « content/browser/web_contents/web_contents_android.cc ('k') | content/common/gpu/gpu_command_buffer_stub.cc » ('j') | no next file with comments »