content/browser/web_contents/web_contents_android.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_android.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_android.cc

diff --git a/content/browser/web_contents/web_contents_android.cc b/content/browser/web_contents/web_contents_android.cc

index 760003589094a5774a563be77a0abd638598d546..dc23623cf475b2867bf7d055483f239f88f0bd7c 100644

--- a/content/browser/web_contents/web_contents_android.cc

+++ b/content/browser/web_contents/web_contents_android.cc

@@ -46,7 +46,7 @@ void JavaScriptResultCallback(const ScopedJavaGlobalRef<jobject>& callback,

const base::Value* result) {

JNIEnv* env = base::android::AttachCurrentThread();

std::string json;

- base::JSONWriter::Write(result, &json);

+ base::JSONWriter::Write(*result, &json);

ScopedJavaLocalRef<jstring> j_json = ConvertUTF8ToJavaString(env, json);

Java_WebContentsImpl_onEvaluateJavaScriptResult(

env, j_json.obj(), callback.obj());

« no previous file with comments | « content/browser/tracing/tracing_ui.cc ('k') | content/browser/webui/web_ui_impl.cc » ('j') | no next file with comments »