components/error_page/renderer/net_error_helper_core.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/error_page/renderer/net_error_helper_core.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/error_page/renderer/net_error_helper_core.cc

diff --git a/components/error_page/renderer/net_error_helper_core.cc b/components/error_page/renderer/net_error_helper_core.cc

index 9a92d742e6c40c2ca0eff58a64c0c39069189026..0c89ec3c29b04beb5059d8d43e37cd4df192d692 100644

--- a/components/error_page/renderer/net_error_helper_core.cc

+++ b/components/error_page/renderer/net_error_helper_core.cc

@@ -198,7 +198,7 @@ std::string CreateRequestBody(

request_dict.Set("params", params_dict.release());

std::string request_body;

- bool success = base::JSONWriter::Write(&request_dict, &request_body);

+ bool success = base::JSONWriter::Write(request_dict, &request_body);

DCHECK(success);

return request_body;

}

« no previous file with comments | « components/domain_reliability/context.cc ('k') | components/error_page/renderer/net_error_helper_core_unittest.cc » ('j') | no next file with comments »