Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: components/domain_reliability/context.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/core/viewer.cc ('k') | components/error_page/renderer/net_error_helper_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/context.cc
diff --git a/components/domain_reliability/context.cc b/components/domain_reliability/context.cc
index 230581f875ccbae73d5be787e16d7de19f47112a..5a35090977f6180c6e370654793c16f25687ede5 100644
--- a/components/domain_reliability/context.cc
+++ b/components/domain_reliability/context.cc
@@ -223,9 +223,7 @@ void DomainReliabilityContext::StartUpload() {
DCHECK(upload_time_.is_null());
upload_time_ = time_->NowTicks();
std::string report_json;
- scoped_ptr<const Value> report_value(CreateReport(upload_time_));
- base::JSONWriter::Write(report_value.get(), &report_json);
- report_value.reset();
+ base::JSONWriter::Write(*CreateReport(upload_time_), &report_json);
size_t collector_index = scheduler_.OnUploadStart();
@@ -281,7 +279,7 @@ scoped_ptr<const Value> DomainReliabilityContext::CreateReport(
resources_value->Append(resource_report.release());
}
- DictionaryValue* report_value = new DictionaryValue();
+ scoped_ptr<DictionaryValue> report_value(new DictionaryValue());
if (!config().version.empty())
report_value->SetString("config_version", config().version);
report_value->SetString("reporter", upload_reporter_string_);
@@ -289,7 +287,7 @@ scoped_ptr<const Value> DomainReliabilityContext::CreateReport(
if (!resources_value->empty())
report_value->Set("resources", resources_value.release());
- return scoped_ptr<const Value>(report_value);
+ return report_value.Pass();
}
void DomainReliabilityContext::MarkUpload() {
« no previous file with comments | « components/dom_distiller/core/viewer.cc ('k') | components/error_page/renderer/net_error_helper_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698