Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: components/dom_distiller/core/page_features_unittest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/core/distiller_page.cc ('k') | components/dom_distiller/core/viewer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/core/page_features_unittest.cc
diff --git a/components/dom_distiller/core/page_features_unittest.cc b/components/dom_distiller/core/page_features_unittest.cc
index 413c55f7b4e8d3f1ba33da711277aced107a8884..1fee593421a333861016b7090211248961cec1c1 100644
--- a/components/dom_distiller/core/page_features_unittest.cc
+++ b/components/dom_distiller/core/page_features_unittest.cc
@@ -70,7 +70,7 @@ TEST(DomDistillerPageFeaturesTest, TestCalculateDerivedFeatures) {
// CalculateDerivedFeaturesFromJSON expects a base::Value of the stringified
// JSON (and not a base::Value of the JSON itself)
std::string stringified_json;
- ASSERT_TRUE(base::JSONWriter::Write(core_features, &stringified_json));
+ ASSERT_TRUE(base::JSONWriter::Write(*core_features, &stringified_json));
scoped_ptr<base::Value> stringified_value(
new base::StringValue(stringified_json));
std::vector<double> derived(
« no previous file with comments | « components/dom_distiller/core/distiller_page.cc ('k') | components/dom_distiller/core/viewer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698