Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2968)

Unified Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
index 95bcf2e80b5f85b8c18087c9095abb0931a7e7a6..289aeec22defaa1d7bebc06ebe8e2f0778b7828f 100644
--- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
+++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
@@ -94,7 +94,7 @@ class WebrtcAudioPrivateTest : public AudioWaitingExtensionTest {
base::ListValue parameters;
AppendTabIdToRequestInfo(&parameters, tab_id);
std::string parameter_string;
- JSONWriter::Write(&parameters, &parameter_string);
+ JSONWriter::Write(parameters, &parameter_string);
scoped_refptr<WebrtcAudioPrivateGetActiveSinkFunction> function =
new WebrtcAudioPrivateGetActiveSinkFunction();
@@ -180,7 +180,7 @@ IN_PROC_BROWSER_TEST_F(WebrtcAudioPrivateTest, GetSinks) {
scoped_ptr<base::Value> result = InvokeGetSinks(&sink_list);
std::string result_string;
- JSONWriter::Write(result.get(), &result_string);
+ JSONWriter::Write(*result, &result_string);
VLOG(2) << result_string;
EXPECT_EQ(devices.size(), sink_list->GetSize());
@@ -229,7 +229,7 @@ IN_PROC_BROWSER_TEST_F(WebrtcAudioPrivateTest, GetActiveSinkNoMediaStream) {
base::ListValue parameters;
AppendTabIdToRequestInfo(&parameters, tab_id);
std::string parameter_string;
- JSONWriter::Write(&parameters, &parameter_string);
+ JSONWriter::Write(parameters, &parameter_string);
scoped_refptr<WebrtcAudioPrivateGetActiveSinkFunction> function =
new WebrtcAudioPrivateGetActiveSinkFunction();
@@ -240,7 +240,7 @@ IN_PROC_BROWSER_TEST_F(WebrtcAudioPrivateTest, GetActiveSinkNoMediaStream) {
browser()));
std::string result_string;
- JSONWriter::Write(result.get(), &result_string);
+ JSONWriter::Write(*result, &result_string);
EXPECT_EQ("\"\"", result_string);
}
@@ -253,7 +253,7 @@ IN_PROC_BROWSER_TEST_F(WebrtcAudioPrivateTest, SetActiveSinkNoMediaStream) {
AppendTabIdToRequestInfo(&parameters, tab_id);
parameters.AppendString("no such id");
std::string parameter_string;
- JSONWriter::Write(&parameters, &parameter_string);
+ JSONWriter::Write(parameters, &parameter_string);
scoped_refptr<WebrtcAudioPrivateSetActiveSinkFunction> function =
new WebrtcAudioPrivateSetActiveSinkFunction();
@@ -299,7 +299,7 @@ IN_PROC_BROWSER_TEST_F(WebrtcAudioPrivateTest, GetAndSetWithMediaStream) {
AppendTabIdToRequestInfo(&parameters, tab_id);
parameters.AppendString(target_device);
std::string parameter_string;
- JSONWriter::Write(&parameters, &parameter_string);
+ JSONWriter::Write(parameters, &parameter_string);
scoped_refptr<WebrtcAudioPrivateSetActiveSinkFunction> function =
new WebrtcAudioPrivateSetActiveSinkFunction();
@@ -345,14 +345,14 @@ IN_PROC_BROWSER_TEST_F(WebrtcAudioPrivateTest, GetAssociatedSink) {
parameters.AppendString(origin.spec());
parameters.AppendString(source_id_in_origin);
std::string parameter_string;
- JSONWriter::Write(&parameters, &parameter_string);
+ JSONWriter::Write(parameters, &parameter_string);
scoped_ptr<base::Value> result(
RunFunctionAndReturnSingleResult(function.get(),
parameter_string,
browser()));
std::string result_string;
- JSONWriter::Write(result.get(), &result_string);
+ JSONWriter::Write(*result, &result_string);
VLOG(2) << "Results: " << result_string;
}
}

Powered by Google App Engine
This is Rietveld 408576698