Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: chrome/browser/extensions/api/storage/settings_sync_util.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/settings_sync_util.cc
diff --git a/chrome/browser/extensions/api/storage/settings_sync_util.cc b/chrome/browser/extensions/api/storage/settings_sync_util.cc
index c187c52dde6e90d907d3f188617d8862d1bb2da2..ccd9a446635211faed34566618d7783b38e06d58 100644
--- a/chrome/browser/extensions/api/storage/settings_sync_util.cc
+++ b/chrome/browser/extensions/api/storage/settings_sync_util.cc
@@ -30,7 +30,7 @@ void PopulateExtensionSettingSpecifics(
specifics->set_key(key);
{
std::string value_as_json;
- base::JSONWriter::Write(&value, &value_as_json);
+ base::JSONWriter::Write(value, &value_as_json);
specifics->set_value(value_as_json);
}
}

Powered by Google App Engine
This is Rietveld 408576698