Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 3a5d3ca03d87f6b3bef5a304bb3474f57fe1a817..69ab19f9fca8a162fcf164dfa22b7248ca16e51b 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -1016,13 +1016,13 @@ void DevToolsUIBindings::CallClientFunction(const std::string& function_name,
std::string javascript = function_name + "(";
if (arg1) {
std::string json;
- base::JSONWriter::Write(arg1, &json);
+ base::JSONWriter::Write(*arg1, &json);
javascript.append(json);
if (arg2) {
- base::JSONWriter::Write(arg2, &json);
+ base::JSONWriter::Write(*arg2, &json);
javascript.append(", ").append(json);
if (arg3) {
- base::JSONWriter::Write(arg3, &json);
+ base::JSONWriter::Write(*arg3, &json);
javascript.append(", ").append(json);
}
}
« no previous file with comments | « chrome/browser/devtools/devtools_protocol.cc ('k') | chrome/browser/extensions/api/debugger/debugger_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698