chrome/browser/extensions/api/debugger/debugger_api.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/debugger/debugger_api.cc

diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc

index 14638efb2966e593f6271a90237775ebb14386e3..27623d9b3f8ed51b76a2741187e5892a6eacc099 100644

--- a/chrome/browser/extensions/api/debugger/debugger_api.cc

+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc

@@ -385,7 +385,7 @@ void ExtensionDevToolsClientHost::SendMessageToBackend(

}

std::string json_args;

- base::JSONWriter::Write(&protocol_request, &json_args);

+ base::JSONWriter::Write(protocol_request, &json_args);

agent_host_->DispatchProtocolMessage(json_args);

}

@@ -666,7 +666,7 @@ void DebuggerSendCommandFunction::SendResponseBody(

base::DictionaryValue* response) {

base::Value* error_body;

if (response->Get("error", &error_body)) {

- base::JSONWriter::Write(error_body, &error_);

+ base::JSONWriter::Write(*error_body, &error_);

SendResponse(false);

return;

}