base/json/json_value_serializer_unittest.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_value_serializer_unittest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/json/json_value_serializer_unittest.cc

diff --git a/base/json/json_value_serializer_unittest.cc b/base/json/json_value_serializer_unittest.cc

index b8aebe0656d3c6ea649dc8e650d73bc9e463e1f2..61860fd50d3dcdca2c6a28c0741418f587fae582 100644

--- a/base/json/json_value_serializer_unittest.cc

+++ b/base/json/json_value_serializer_unittest.cc

@@ -302,7 +302,7 @@ TEST(JSONValueSerializerTest, StringEscape) {

std::string output_js;

DictionaryValue valueRoot;

valueRoot.SetString("all_chars", all_chars);

- JSONWriter::Write(&valueRoot, &output_js);

+ JSONWriter::Write(valueRoot, &output_js);

ASSERT_EQ(expected_output, output_js);

// Test JSONValueSerializer interface (uses JSONWriter).

« no previous file with comments | « base/json/json_string_value_serializer.cc ('k') | base/json/json_writer.h » ('j') | no next file with comments »