base/json/json_string_value_serializer.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_string_value_serializer.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/json/json_string_value_serializer.cc

diff --git a/base/json/json_string_value_serializer.cc b/base/json/json_string_value_serializer.cc

index debf9f088d1f3acf5a1c588d8ab2759be81969f8..3787fdb6d100e96b3f713880af254ecdd6d788e9 100644

--- a/base/json/json_string_value_serializer.cc

+++ b/base/json/json_string_value_serializer.cc

@@ -37,7 +37,7 @@ bool JSONStringValueSerializer::SerializeInternal(const Value& root,

if (pretty_print_)

options |= base::JSONWriter::OPTIONS_PRETTY_PRINT;

- return base::JSONWriter::WriteWithOptions(&root, options, json_string_);

+ return base::JSONWriter::WriteWithOptions(root, options, json_string_);

}

JSONStringValueDeserializer::JSONStringValueDeserializer(

« no previous file with comments | « android_webview/browser/aw_dev_tools_discovery_provider.cc ('k') | base/json/json_value_serializer_unittest.cc » ('j') | no next file with comments »