Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1131073002: Change content/browser GURL::SchemeIsSecure calls to SchemeIsCryptographic. (Closed)

Created:
5 years, 7 months ago by palmer
Modified:
5 years, 7 months ago
Reviewers:
michaeln, felt, mmenke
CC:
chromium-reviews, michaeln, darin-cc_chromium.org, jam, lgarron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change content/browser GURL::SchemeIsSecure calls to SchemeIsCryptographic. BUG=362214 TBR=michaeln Committed: https://crrev.com/179b32c0a35ad3070b9b28ce05ac986677b7c521 Cr-Commit-Position: refs/heads/master@{#328857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/browser/appcache/appcache_update_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/ssl/ssl_policy.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
palmer
5 years, 7 months ago (2015-05-07 20:28:38 UTC) #2
mmenke
loader/ LGTM
5 years, 7 months ago (2015-05-07 20:34:42 UTC) #3
felt
content/browser/ssl LGTM
5 years, 7 months ago (2015-05-07 20:59:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131073002/1
5 years, 7 months ago (2015-05-07 21:13:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 22:19:17 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 22:21:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/179b32c0a35ad3070b9b28ce05ac986677b7c521
Cr-Commit-Position: refs/heads/master@{#328857}

Powered by Google App Engine
This is Rietveld 408576698