content/browser/loader/resource_dispatcher_host_impl.cc - Issue 1131073002: Change content/browser GURL::SchemeIsSecure calls to SchemeIsCryptographic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 1131073002: Change content/browser GURL::SchemeIsSecure calls to SchemeIsCryptographic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index 3d7565adba4a21e237fca0f7507db510c85366d1..d758f687987af444c94f1ed25d29cfbd25fc31d5 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -862,7 +862,7 @@ void ResourceDispatcherHostImpl::DidFinishLoading(ResourceLoader* loader) {

"Net.ErrorCodesForMainFrame3",

-loader->request()->status().error());

- if (loader->request()->url().SchemeIsSecure()) {

+ if (loader->request()->url().SchemeIsCryptographic()) {

if (loader->request()->url().host() == "www.google.com") {

UMA_HISTOGRAM_SPARSE_SLOWLY("Net.ErrorCodesForHTTPSGoogleMainFrame2",

-loader->request()->status().error());

@@ -887,7 +887,7 @@ void ResourceDispatcherHostImpl::DidFinishLoading(ResourceLoader* loader) {

-loader->request()->status().error());

}

- if (loader->request()->url().SchemeIsSecure()) {

+ if (loader->request()->url().SchemeIsCryptographic()) {

RecordCertificateHistograms(loader->request()->ssl_info(),

info->GetResourceType());

}

« no previous file with comments | « content/browser/appcache/appcache_update_job.cc ('k') | content/browser/ssl/ssl_policy.cc » ('j') | no next file with comments »