Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1130993003: Reland: Make V8 extras a separate type of native (Closed)

Created:
5 years, 7 months ago by domenic
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@fix-snapshot
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-land: Make V8 extras a separate type of native Instead of making them an extra option that gets passed in and compiled at the end of the natives file for a given run of js2c, we now make them a separate run of js2c with a separate natives file output. This natives file output is then compiled in the bootstrapper. It is not part of the snapshot (yet), but instead is treated similar to the experimental natives, just without any of the complexity that comes from tieing the behavior to flags. We also don't need counterparts to InitializeExperimentalGlobal and InstallExperimentalNativeFunctions (yet?). This fixes the issue with https://codereview.chromium.org/1129743003 by making the dummy file that is generated for snapshots with no extras (or no experimental features) nonempty. R=yangguo@chromium.org, jochen@chromium.org BUG= Committed: https://crrev.com/570fca61fc04fafa7cbcd773f904ef58cb015576 Cr-Commit-Position: refs/heads/master@{#28311}

Patch Set 1 #

Patch Set 2 : Fix js2c.py's dummy files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -43 lines) Patch
M BUILD.gn View 6 chunks +37 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 8 chunks +32 lines, -3 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/snapshot/natives.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/snapshot/natives-external.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/startup-data-util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 7 chunks +31 lines, -5 lines 0 comments Download
M tools/js2c.py View 1 8 chunks +29 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
domenic
5 years, 7 months ago (2015-05-07 17:52:50 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-07 17:56:46 UTC) #2
Yang
On 2015/05/07 17:56:46, jochen wrote: > lgtm lgtm.
5 years, 7 months ago (2015-05-07 19:04:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130993003/20001
5 years, 7 months ago (2015-05-08 08:07:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-08 08:44:52 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 08:45:10 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/570fca61fc04fafa7cbcd773f904ef58cb015576
Cr-Commit-Position: refs/heads/master@{#28311}

Powered by Google App Engine
This is Rietveld 408576698