Make V8 extras a separate type of native

Make V8 extras a separate type of native

Instead of making them an extra option that gets passed in and compiled
at the end of the natives file for a given run of js2c, we now make them a
separate run of js2c with a separate natives file output.

This natives file output is then compiled in the bootstrapper. It is not part
of the snapshot (yet), but instead is treated similar to the experimental
natives, just without any of the complexity that comes from tieing the
behavior to flags. We also don't add counterparts to
InitializeExperimentalGlobal and InstallExperimentalNativeFunctions, yet.

R=yangguo@chromium.org, jochen@chromium.org
BUG=

Committed: https://crrev.com/c93aff4ac63ad9ffb6318e750335208de32b7902
Cr-Commit-Position: refs/heads/master@{#28296}

[jochen (gone - plz use gerrit), 2015-05-06 13:07:43]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-06 13:07:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129743003/1

[jochen (gone - plz use gerrit), 2015-05-06 13:09:42]

can you also update the BUILD.gn file?

[commit-bot: I haz the power, 2015-05-06 13:13:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-06 13:13:25]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/148)

[domenic, 2015-05-06 13:36:41]

On 2015/05/06 at 13:09:42, jochen wrote:
> can you also update the BUILD.gn file?

BUILD.gn updated; build problems fixed (hopefully) by introducing a dummy file.

[jochen (gone - plz use gerrit), 2015-05-06 13:41:11]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-06 13:41:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129743003/20001

[commit-bot: I haz the power, 2015-05-06 13:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-06 13:54:23]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Yang, 2015-05-06 13:59:54]

The non build system part look good. I'll give the other parts another look.

https://codereview.chromium.org/1129743003/diff/20001/tools/js2c.py
File tools/js2c.py (right):

https://codereview.chromium.org/1129743003/diff/20001/tools/js2c.py#newcode417
tools/js2c.py:417: filters = BuildExtraFilterChain if native_type == "EXTRA"
else BuildFilterChain(macro_file, message_template_file)
Can we have a normal if-else here please? Would also keep this below 80 chars
per col.

https://codereview.chromium.org/1129743003/diff/20001/tools/js2c.py#newcode577
tools/js2c.py:577: help="type parameter for NativesCollection template (see
NativeType enum)")
keeping 80 char limit would be nice.

[domenic, 2015-05-06 14:41:48]

On 2015/05/06 at 13:59:54, yangguo wrote:
> The non build system part look good. I'll give the other parts another look.
> 
> https://codereview.chromium.org/1129743003/diff/20001/tools/js2c.py
> File tools/js2c.py (right):
> 
> https://codereview.chromium.org/1129743003/diff/20001/tools/js2c.py#newcode417
> tools/js2c.py:417: filters = BuildExtraFilterChain if native_type == "EXTRA"
else BuildFilterChain(macro_file, message_template_file)
> Can we have a normal if-else here please? Would also keep this below 80 chars
per col.
> 
> https://codereview.chromium.org/1129743003/diff/20001/tools/js2c.py#newcode577
> tools/js2c.py:577: help="type parameter for NativesCollection template (see
NativeType enum)")
> keeping 80 char limit would be nice.

Fixed both. Waiting on https://codereview.chromium.org/1127133002 for the gn
build

[jochen (gone - plz use gerrit), 2015-05-07 09:01:19]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-07 09:01:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129743003/40001

[commit-bot: I haz the power, 2015-05-07 09:46:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 09:46:53]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[jochen (gone - plz use gerrit), 2015-05-07 09:56:30]

https://codereview.chromium.org/1129743003/diff/40001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1129743003/diff/40001/src/bootstrapper.cc#new...
src/bootstrapper.cc:1464: return CompileNative(isolate, name, source_code);
CompileNative calls CompileScriptCached with use_runtime_context set to true
which in turn invokes CompileScript with NATIVES_CODE which then is translated
to set_native() on the ParseInfo object.

I guess we want to keep NATIVES_CODE, but use another flag to decide whether or
not to call set_native(). Maybe a compiler option we could pass instead of
kNoCompilerOptions?

probably something for another CL...

[domenic, 2015-05-07 11:18:34]

The CQ bit was checked by domenic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-07 11:18:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129743003/60001

[commit-bot: I haz the power, 2015-05-07 11:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 11:18:47]

Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jochen (gone - plz use gerrit), 2015-05-07 11:44:11]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-07 11:44:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129743003/60001

[jochen (gone - plz use gerrit), 2015-05-07 11:45:14]

lgtm

[Yang, 2015-05-07 11:46:51]

On 2015/05/07 11:45:14, jochen wrote:
> lgtm

lgtm.

[commit-bot: I haz the power, 2015-05-07 12:09:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 12:09:08]

Dry run: This issue passed the CQ dry run.

[domenic, 2015-05-07 12:42:30]

The CQ bit was checked by domenic@chromium.org

[commit-bot: I haz the power, 2015-05-07 12:42:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129743003/60001

[commit-bot: I haz the power, 2015-05-07 12:44:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-07 12:44:27]

Patchset 4 (id:??) landed as
https://crrev.com/c93aff4ac63ad9ffb6318e750335208de32b7902
Cr-Commit-Position: refs/heads/master@{#28296}

[domenic, 2015-05-07 14:09:21]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1131903002/ by domenic@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28db....