Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1130913007: Removing primaryFontHasGlyphForCharacter method (Closed)

Created:
5 years, 7 months ago by h.joshi
Modified:
5 years, 7 months ago
Reviewers:
behdad_google, pdr., eae, behdad
CC:
blink-reviews, Rik, danakj, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing primaryFontHasGlyphForCharacter method Method primaryFontHasGlyphForCharacter was using duplicate code already present in SimpleFontData and has single caller. Done as per comments in https://codereview.chromium.org/870523003/#msg15 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195598

Patch Set 1 #

Patch Set 2 : Comment fixes #

Patch Set 3 : Rebase patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M Source/core/style/ComputedStyle.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/platform/fonts/Font.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/fonts/Font.cpp View 1 2 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 29 (15 generated)
h.joshi
Pls review
5 years, 7 months ago (2015-05-19 18:53:22 UTC) #2
behdad_google
lgtm
5 years, 7 months ago (2015-05-19 19:14:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130913007/1
5 years, 7 months ago (2015-05-20 01:44:34 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-20 01:44:41 UTC) #8
h.joshi
@Emil: Pls review
5 years, 7 months ago (2015-05-20 02:01:51 UTC) #10
pdr.
On 2015/05/20 at 02:01:51, h.joshi wrote: > @Emil: Pls review LGTM It looks like there ...
5 years, 7 months ago (2015-05-20 03:00:06 UTC) #11
h.joshi
@pdr: Thank you, Removed method primaryFontHasGlyphForCharacter entirely as it is used in one place only. ...
5 years, 7 months ago (2015-05-20 05:24:34 UTC) #12
pdr.
lgtm
5 years, 7 months ago (2015-05-20 05:27:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130913007/20001
5 years, 7 months ago (2015-05-20 05:27:51 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/45000) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 7 months ago (2015-05-20 05:30:54 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130913007/40001
5 years, 7 months ago (2015-05-20 05:35:15 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/45005)
5 years, 7 months ago (2015-05-20 05:49:21 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130913007/60001
5 years, 7 months ago (2015-05-20 05:51:01 UTC) #28
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 08:01:07 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195598

Powered by Google App Engine
This is Rietveld 408576698