Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Issue 1130903004: [Mac] Fix download item text sometimes being misaligned. (Closed)

Created:
5 years, 7 months ago by Alexei Svitkine (slow)
Modified:
5 years, 7 months ago
Reviewers:
asanka
CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix download item text sometimes being misaligned. There's two possible stable values for |titleY_|, kPrimaryTextPosTop - when status message is visible, kPrimaryTextOnlyPosTop - when status message is not visible. There was an inconistency how this was being initialized - as isStatusTextVisible_ was being set to NO but the value was set to kPrimaryTextPosTop. The text would then be misaligned if the code would take the -hideSecondaryTitle in -setStateFromDownload:. This CL fixes the issue and updates the test to check this. BUG=484848 Committed: https://crrev.com/293783badd2363e2135d593cb5e36e04a163c92f Cr-Commit-Position: refs/heads/master@{#329305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/download/download_item_cell.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.mm View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell_unittest.mm View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Alexei Svitkine (slow)
5 years, 7 months ago (2015-05-11 21:44:14 UTC) #2
asanka
lgtm
5 years, 7 months ago (2015-05-11 23:47:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130903004/1
5 years, 7 months ago (2015-05-12 00:59:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 01:09:29 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 01:11:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/293783badd2363e2135d593cb5e36e04a163c92f
Cr-Commit-Position: refs/heads/master@{#329305}

Powered by Google App Engine
This is Rietveld 408576698