chrome/browser/ui/cocoa/download/download_item_cell.mm - Issue 1130903004: [Mac] Fix download item text sometimes being misaligned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_item_cell.mm

Issue 1130903004: [Mac] Fix download item text sometimes being misaligned. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/download/download_item_cell.h ('k') | chrome/browser/ui/cocoa/download/download_item_cell_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/download/download_item_cell.mm

diff --git a/chrome/browser/ui/cocoa/download/download_item_cell.mm b/chrome/browser/ui/cocoa/download/download_item_cell.mm

index 0d75b09f4453e7a6cc604eed5c2e1bf939894f3c..e712f95b34eb7af6577261ad175b7533ec6bdbcb 100644

--- a/chrome/browser/ui/cocoa/download/download_item_cell.mm

+++ b/chrome/browser/ui/cocoa/download/download_item_cell.mm

@@ -138,7 +138,7 @@ void DummyRTLMirror(gfx::Rect* bounds) {

- (void)setInitialState {

isStatusTextVisible_ = NO;

- titleY_ = kPrimaryTextPosTop;

+ titleY_ = kPrimaryTextOnlyPosTop;

statusAlpha_ = 0.0;

indeterminateProgressAngle_ = DownloadShelf::kStartAngleDegrees;

@@ -727,6 +727,10 @@ void DummyRTLMirror(gfx::Rect* bounds) {

return statusAlpha_;

}

+- (CGFloat)titleY {

+ return titleY_;

- (void)skipVisibilityAnimation {

[toggleStatusVisibilityAnimation_ setCurrentProgress:1.0];

}