Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 11309007: profiler: log solib addresses unconditionally (Closed)

Created:
8 years, 1 month ago by bnoordhuis1
Modified:
7 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

profiler: log solib addresses unconditionally Make --prof_lazy log the addresses of shared libraries. Without those addresses, the output of the tick processor is not very useful for node.js applications. Address logging was disabled for --prof-lazy in r3154 for reasons that no longer apply: the profiler is started on demand and hence looking up the addresses is deferred until it's actually necessary. Committed: http://code.google.com/p/v8/source/detail?r=13540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/log.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bnoordhuis1
Make --prof_lazy log the addresses of shared libraries. Without those addresses, the output of the ...
8 years, 1 month ago (2012-11-20 21:55:37 UTC) #1
bnoordhuis
Can someone review this, please? It's been in the queue for three months now.
7 years, 11 months ago (2013-01-26 18:05:33 UTC) #2
Michael Starzinger
LGTM (I'll land this).
7 years, 10 months ago (2013-01-29 14:37:19 UTC) #3
Michael Starzinger
7 years, 10 months ago (2013-01-29 14:39:15 UTC) #4
Message was sent while issue was closed.
Committed manually as r13540 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698