Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: src/log.cc

Issue 11309007: profiler: log solib addresses unconditionally (Closed)
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 engaged_(false), 276 engaged_(false),
277 running_(false), 277 running_(false),
278 paused_(false) { 278 paused_(false) {
279 } 279 }
280 280
281 281
282 void Profiler::Engage() { 282 void Profiler::Engage() {
283 if (engaged_) return; 283 if (engaged_) return;
284 engaged_ = true; 284 engaged_ = true;
285 285
286 // TODO(mnaganov): This is actually "Chromium" mode. Flags need to be revised. 286 OS::LogSharedLibraryAddresses();
287 // http://code.google.com/p/v8/issues/detail?id=487
288 if (!FLAG_prof_lazy) {
289 OS::LogSharedLibraryAddresses();
290 }
291 287
292 // Start thread processing the profiler buffer. 288 // Start thread processing the profiler buffer.
293 running_ = true; 289 running_ = true;
294 Start(); 290 Start();
295 291
296 // Register to get ticks. 292 // Register to get ticks.
297 LOGGER->ticker_->SetProfiler(this); 293 LOGGER->ticker_->SetProfiler(this);
298 294
299 LOGGER->ProfilerBeginEvent(); 295 LOGGER->ProfilerBeginEvent();
300 } 296 }
(...skipping 1567 matching lines...) Expand 10 before | Expand all | Expand 10 after
1868 void SamplerRegistry::RemoveActiveSampler(Sampler* sampler) { 1864 void SamplerRegistry::RemoveActiveSampler(Sampler* sampler) {
1869 ASSERT(sampler->IsActive()); 1865 ASSERT(sampler->IsActive());
1870 ScopedLock lock(active_samplers_mutex); 1866 ScopedLock lock(active_samplers_mutex);
1871 ASSERT(active_samplers_ != NULL); 1867 ASSERT(active_samplers_ != NULL);
1872 bool removed = active_samplers_->RemoveElement(sampler); 1868 bool removed = active_samplers_->RemoveElement(sampler);
1873 ASSERT(removed); 1869 ASSERT(removed);
1874 USE(removed); 1870 USE(removed);
1875 } 1871 }
1876 1872
1877 } } // namespace v8::internal 1873 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698