Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1130893008: Use BoringSSL in the implementation of ClearKey for Chromecast. (Closed)

Created:
5 years, 7 months ago by dougsteed
Modified:
5 years, 7 months ago
Reviewers:
ddorwin, gunsch
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, gunsch+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use BoringSSL in the implementation of ClearKey for Chromecast. (Previously, this was used only with the "Chrome" branding). BUG=488572 R=gunsch@chromium.org Committed: https://crrev.com/defd2af08f3753687cb2d86b34bbec9da31ccbab Cr-Commit-Position: refs/heads/master@{#330156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chromecast/media/media.gyp View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
dougsteed
5 years, 7 months ago (2015-05-15 18:07:23 UTC) #1
gunsch
lgtm
5 years, 7 months ago (2015-05-15 18:07:50 UTC) #2
ddorwin
Drive-by commit message nit: Wasn't this only used with branding != "Chrome" before?
5 years, 7 months ago (2015-05-15 18:09:22 UTC) #4
gunsch
The internal one was linking in openssl in some situations, and used to be to ...
5 years, 7 months ago (2015-05-15 18:11:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130893008/1
5 years, 7 months ago (2015-05-15 18:50:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 19:07:37 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/defd2af08f3753687cb2d86b34bbec9da31ccbab Cr-Commit-Position: refs/heads/master@{#330156}
5 years, 7 months ago (2015-05-15 19:09:33 UTC) #9
gunsch
5 years, 7 months ago (2015-05-15 23:22:38 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1141243003/ by gunsch@chromium.org.

The reason for reverting is: Temporary revert until Monday (blocked on some
other internal changes)..

Powered by Google App Engine
This is Rietveld 408576698