Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1130893007: Aria-required not working for Input elements on Mac & Win. (Closed)

Created:
5 years, 7 months ago by shreeramk
Modified:
5 years, 7 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, je_julie, nektarios, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Aria-required not working for Input elements on Mac & Win. BUG=487401 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195849

Patch Set 1 #

Patch Set 2 : adding layout test #

Patch Set 3 : Adding more tests #

Patch Set 4 : fixing mac failure #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
A LayoutTests/accessibility/input-aria-required.html View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/input-aria-required-expected.txt View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/platform/mac/accessibility/input-aria-required-expected.txt View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
shreeramk
Please review. Thanks!
5 years, 7 months ago (2015-05-14 04:10:50 UTC) #2
dmazzoni
Can you add a test demonstrating the bug? Since this is a Blink fix you ...
5 years, 7 months ago (2015-05-14 16:57:41 UTC) #3
shreeramk
On 2015/05/14 16:57:41, dmazzoni wrote: > Can you add a test demonstrating the bug? > ...
5 years, 7 months ago (2015-05-15 05:05:55 UTC) #4
dmazzoni
lgtm Great, could you please also add three more test cases: 1. An input element ...
5 years, 7 months ago (2015-05-15 21:57:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130893007/40001
5 years, 7 months ago (2015-05-18 03:18:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/55459)
5 years, 7 months ago (2015-05-18 09:20:09 UTC) #10
shreeramk
@Dominic: Since I don't have mac system. Is there anyway to check this mac failure ...
5 years, 7 months ago (2015-05-20 15:15:23 UTC) #11
dmazzoni
On 2015/05/20 15:15:23, shreeramk wrote: > @Dominic: Since I don't have mac system. Is there ...
5 years, 7 months ago (2015-05-20 15:19:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130893007/80001
5 years, 7 months ago (2015-05-25 04:25:42 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-25 05:34:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195849

Powered by Google App Engine
This is Rietveld 408576698