Aria-required not working for Input elements on Mac & Win.

Aria-required not working for Input elements on Mac & Win.

BUG=487401
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195849

[shreeramk, 2015-05-14 04:10:49]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[shreeramk, 2015-05-14 04:10:50]

Please review.

Thanks!

[dmazzoni, 2015-05-14 16:57:41]

Can you add a test demonstrating the bug?

Since this is a Blink fix you should be able to write a LayoutTest - you can
call isRequired on any AX object from a LayoutTest.

See isRequired in LayoutTests/accessibility/canvas-fallback-content-2.html as
one example of where it's tested.

[shreeramk, 2015-05-15 05:05:55]

On 2015/05/14 16:57:41, dmazzoni wrote:
> Can you add a test demonstrating the bug?
> 
> Since this is a Blink fix you should be able to write a LayoutTest - you can
> call isRequired on any AX object from a LayoutTest.
> 
> See isRequired in LayoutTests/accessibility/canvas-fallback-content-2.html as
> one example of where it's tested.

Layout Test added. PTAL. Thanks!!

[dmazzoni, 2015-05-15 21:57:22]

lgtm

Great, could you please also add three more test cases:

1. An input element without "required"
2. An input element with aria-required="false"
3. An input element with "required" and aria-required="false" (I think this
should be isRequired=true, because the native attribute wins)

OK to submit after adding those

[shreeramk, 2015-05-18 03:18:24]

The CQ bit was checked by shreeram.k@samsung.com

[shreeramk, 2015-05-18 03:18:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1130893007/#ps40001
(title: "Adding more tests")

[commit-bot: I haz the power, 2015-05-18 03:18:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130893007/40001

[commit-bot: I haz the power, 2015-05-18 09:20:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-18 09:20:09]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/55459)

[shreeramk, 2015-05-20 15:15:23]

@Dominic: Since I don't have mac system. Is there anyway to check this mac
failure expectation?

[dmazzoni, 2015-05-20 15:19:32]

On 2015/05/20 15:15:23, shreeramk wrote:
> @Dominic: Since I don't have mac system. Is there anyway to check this mac
> failure expectation?

Yes, in the results page, look for archive_webkit_tests_results and click on the
(zip) link under that. The zip file you'll get contains all of the relevant
output, like the expected and actual results when the test was run.

[shreeramk, 2015-05-25 04:25:29]

The CQ bit was checked by shreeram.k@samsung.com

[shreeramk, 2015-05-25 04:25:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1130893007/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-05-25 04:25:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130893007/80001

[commit-bot: I haz the power, 2015-05-25 05:34:56]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195849