Source/modules/accessibility/AXNodeObject.cpp - Issue 1130893007: Aria-required not working for Input elements on Mac & Win.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 1130893007: Aria-required not working for Input elements on Mac & Win. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXNodeObject.cpp

diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp

index 5fb48fb68fe299f641808123f5c0c9ba45970c6f..c074372d55ff058355f1228540f0e0ccbde4265b 100644

--- a/Source/modules/accessibility/AXNodeObject.cpp

+++ b/Source/modules/accessibility/AXNodeObject.cpp

@@ -1047,7 +1047,7 @@ bool AXNodeObject::isReadOnly() const

bool AXNodeObject::isRequired() const

{

Node* n = this->node();

- if (n && (n->isElementNode() && toElement(n)->isFormControlElement()))

+ if (n && (n->isElementNode() && toElement(n)->isFormControlElement()) && hasAttribute(requiredAttr))

return toHTMLFormControlElement(n)->isRequired();

if (equalIgnoringCase(getAttribute(aria_requiredAttr), "true"))

« no previous file with comments | « LayoutTests/platform/mac/accessibility/input-aria-required-expected.txt ('k') | no next file » | no next file with comments »